linux-kernel - Re: [PATCH 21/39] irqdomain: Introduce irq_resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Jun 2021 08:24:14 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Qian Cai <quic_qiancai@...cinc.com>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Ley Foon Tan <ley.foon.tan@...el.com>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        Vineet Gupta <vgupta@...opsys.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Russell King <linux@...linux.org.uk>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Clark <robdclark@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee.jones@...aro.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        kernel-team@...roid.com
Subject: Re: [PATCH 21/39] irqdomain: Introduce irq_resolve_mapping()

On 2021-06-10 03:22, Qian Cai wrote:
> On 5/20/2021 12:37 PM, Marc Zyngier wrote:
>> Rework irq_find_mapping() to return an irq_desc pointer, and
>> rename the result to irq_resolve_mapping().
>> 
>> irq_find_mapping() is then rewritten in terms of ir_resolve_mapping().
>> 
>> Signed-off-by: Marc Zyngier <maz@...nel.org>
> 
> Marc, there is an use-after-free that "git blame" pointed to this
> commit. Any thoughts?
> 
> __irq_resolve_mapping+0x34c/0x360:
> __irq_resolve_mapping at /usr/src/linux-next/kernel/irq/irqdomain.c:917

Yup, this was reported yesterday by John Gary. I'm on it.

         M.
-- 
Jazz is not dead. It just smells funny...