linux-kernel - Re: linux-next: NVME using PCI legacy interrupts only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k0n2qh38.wl-maz@kernel.org>
Date:   Thu, 10 Jun 2021 09:06:19 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: linux-next: NVME using PCI legacy interrupts only

On Wed, 09 Jun 2021 19:43:57 +0100,
Heiner Kallweit <hkallweit1@...il.com> wrote:
> 
> I found that on linux-next from June 8th my nvme disk is using legacy
> interrupts only. Some debugging lead me to irq_find_mapping() in
> msi_domain_alloc() returning -EEXIST.
> 
> The nvme core first allocates a MSI-X interrupt for setup purposes
> and later frees it and allocates the final number of MSI-X interrupts.
> 
> The following experimental change brought back the MSI-X interrupts.
> This makes me think that somehow freeing a MSI-X interrupt doesn't
> free it completely. I didn't see this behavior a few days ago,
> therefore I think it's related to the recent changes to
> irqdomain/genirq.
> 
> Didn't do a bisect yet, maybe you have an idea already.

Yeah, recent changes in the irqdomain subsystem seem to have uncovered
a long standing issue where we are leaving dangling references in some
domains....

I've now dropped the branch from -next while I figure it out.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.