linux-kernel - Re: [PATCH 1/2] serial: stm32: reset dma buffers during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc153364-b78a-3199-129f-5c6fb7353d49@foss.st.com>
Date:   Thu, 10 Jun 2021 10:54:20 +0200
From:   Erwan LE RAY <erwan.leray@...s.st.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Jiri Slaby <jslaby@...e.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <linux-serial@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
        Valentin Caron <valentin.caron@...s.st.com>,
        Amelie Delaunay <amelie.delaunay@...s.st.com>
Subject: Re: [PATCH 1/2] serial: stm32: reset dma buffers during probe

Hi Greg,

Thanks for your question. This old patch is finally not necessary any more.
You can cancel this series, I will resend the second patch.

Best regards, Erwan.


On 5/27/21 11:49 AM, Greg Kroah-Hartman wrote:
> On Thu, May 27, 2021 at 11:15:36AM +0200, Erwan Le Ray wrote:
>> Reset Rx and Tx dma buffers during probe to avoid freeing
>> invalid buffer in no dma mode.
>>
>> Signed-off-by: Erwan Le Ray <erwan.leray@...s.st.com>
>>
>> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
>> index c2ae7b392b86..2ac3b30477a7 100644
>> --- a/drivers/tty/serial/stm32-usart.c
>> +++ b/drivers/tty/serial/stm32-usart.c
>> @@ -1168,6 +1168,8 @@ static struct stm32_port *stm32_usart_of_get_port(struct platform_device *pdev)
>>   	stm32_ports[id].cr1_irq = USART_CR1_RXNEIE;
>>   	stm32_ports[id].cr3_irq = 0;
>>   	stm32_ports[id].last_res = RX_BUF_L;
>> +	stm32_ports[id].rx_dma_buf = 0;
>> +	stm32_ports[id].tx_dma_buf = 0;
>>   	return &stm32_ports[id];
>>   }
>>   
>> -- 
>> 2.17.1
>>
> 
> Is this a bugfix?  if so, what commit does this fix and does it need to
> be backported anywhere?
> 
> thanks,
> 
> greg k-h
>