linux-kernel - Re: [PATCH v3] usb: dwc3: support 64 bit DMA in platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871r9a2htf.fsf@kernel.org>
Date:   Thu, 10 Jun 2021 12:24:28 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Sven Peter <sven@...npeter.dev>, linux-usb@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Sven Peter <sven@...npeter.dev>
Subject: Re: [PATCH v3] usb: dwc3: support 64 bit DMA in platform driver


Hi,

Sven Peter <sven@...npeter.dev> writes:
> Currently, the dwc3 platform driver does not explicitly ask for
> a DMA mask. This makes it fall back to the default 32-bit mask which
> breaks the driver on systems that only have RAM starting above the
> first 4G like the Apple M1 SoC.
>
> Fix this by calling dma_set_mask_and_coherent with a 64bit mask.
>
> Signed-off-by: Sven Peter <sven@...npeter.dev>

Acked-by: Felipe Balbi <balbi@...nel.org>

> ---
>
> Third time's a charm I hope - this time much simpler :)
>
> I still think this change should be fairly low risk.
>
> Unfortunately I only have the Apple M1 to test this on but here

wait a minute. The M1 includes a dwc3? That's awesome. Mind sharing a
regdump? Should be in debugfs.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (512 bytes)