linux-kernel - Re: [PATCH v2] perf stat: Disable NMI watchdog message on hybrid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8faa16cf-561e-cd31-7fb2-bfad3ae27782@linux.intel.com>
Date:   Thu, 10 Jun 2021 09:04:57 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2] perf stat: Disable NMI watchdog message on hybrid

Hi Jiri,

On 6/10/2021 4:26 AM, Jiri Olsa wrote:
>> +static bool is_mixed_hybrid_group(struct evsel *counter)
>> +{
>> +	struct evlist *evlist = counter->evlist;
>> +	struct evsel *pos;
>> +
>> +	evlist__for_each_entry(evlist, pos) {
>> +		if (perf_pmu__is_hybrid(pos->pmu_name))
>> +			return true;
>> +	}
> so we care if there's at least one hybrid event in the list right?
> it can be all full with just hybrid events, but the function name
> suggests it's mixed with normal events
> 
> jirka
> 

Yes, that's right. We only care there is at least one hybrid event in the evlist.

So do we change the function name to evlist__has_hybrid_event?

Thanks
Jin Yao