linux-kernel - Re: arch/x86/lib/copy_mc.c:30:1: warning: no previous prototype for 'copy_mc_fragile_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4ioLR4UyG_h3Z6Yaym9Yfg1CsQ0o_2gtrUbd3SKiS9i6A@mail.gmail.com>
Date:   Wed, 9 Jun 2021 17:13:25 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     "Luck, Tony" <tony.luck@...el.com>
Cc:     lkp <lkp@...el.com>,
        "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Borislav Petkov <bp@...e.de>
Subject: Re: arch/x86/lib/copy_mc.c:30:1: warning: no previous prototype for 'copy_mc_fragile_handle_tail'

On Wed, Jun 9, 2021 at 4:55 PM Luck, Tony <tony.luck@...el.com> wrote:
>
> > This routine is only ever called from ASM code, so the fact that there
> > is no C declaration is expected.
>
> Does the asm code really need to call back into C?
>
> Could you just have the asm code do "jmp .L_read_trailing_bytes" (might need to only do that if %ecx is non-zero)?

I could... it turns out when Peter did this:

3693ca81151e x86/uaccess: Move copy_user_handle_tail() into asm

...he did not also go fixup my cargo culting. I'll take a look...