linux-kernel - Re: [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210610125209.glrd2qlpwqiha24h@gilmour>
Date:   Thu, 10 Jun 2021 14:52:09 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Icenowy Zheng <icenowy@...c.io>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Heinrich Schuchardt <xypron.glpk@....de>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change
 RGMII mode to TXID

On Wed, Jun 09, 2021 at 04:38:43PM +0800, Icenowy Zheng wrote:
> Although the schematics of Pine A64-LTS and SoPine Baseboard shows both
> the RX and TX internal delay are enabled, they're using the same broken
> RTL8211E chip batch with Pine A64+, so they should use TXID instead, not
> ID.
> 
> In addition, by checking the real components soldered on both a SoPine
> Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and
> GR70 NC) despite the schematics says it's enabled. It's a common
> situation for Pine64 boards that the NC information on schematics is not
> the same with the board.
> 
> So the RGMII delay mode should be TXID on these boards.
> 
> Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-id")
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>

Applied, thanks
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)