lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Jun 2021 02:12:27 +0000 From: ء¤؟لار(JOUNG YOHAN) Mobile SE <yohan.joung@...com> To: "daejun7.park@...sung.com" <daejun7.park@...sung.com> CC: "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>, "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>, "avri.altman@....com" <avri.altman@....com>, "bvanassche@....org" <bvanassche@....org>, "cang@...eaurora.org" <cang@...eaurora.org>, "d_hyun.kwon@...sung.com" <d_hyun.kwon@...sung.com>, Greg KH <gregkh@...uxfoundation.org>, "huobean@...il.com" <huobean@...il.com>, "j-young.choi@...sung.com" <j-young.choi@...sung.com>, "jaemyung.lee@...sung.com" <jaemyung.lee@...sung.com>, "javier.gonz@...sung.com" <javier.gonz@...sung.com>, "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "jh.i.park@...sung.com" <jh.i.park@...sung.com>, "jieon.seol@...sung.com" <jieon.seol@...sung.com>, "keosung.park@...sung.com" <keosung.park@...sung.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>, "sungjun07.park@...sung.com" <sungjun07.park@...sung.com> Subject: Re: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h index 6e6a0252dc15..b1128b0ce486 100644 --- a/drivers/scsi/ufs/ufshpb.h +++ b/drivers/scsi/ufs/ufshpb.h @@ -30,19 +30,29 @@ #define PINNED_NOT_SET U32_MAX /* hpb support chunk size */ -#define HPB_MULTI_CHUNK_HIGH 1 +#define HPB_LEGACY_CHUNK_HIGH 1 +#define HPB_MULTI_CHUNK_LOW 7 +#define HPB_MULTI_CHUNK_HIGH 128 According to the JEDEC spec, bMAX_DATA_SIZE_FOR_HPB_SINGLE_CMD can be set from 4kb to 1024kb. The transfer length should be provided up to 1020kb or 1024kb. Why did you set HPB_MULTI_CHUNK_HIGH to 128? It can sends the hpb command up to 512kb. This doesn't seem to match the specs. Thanks Yohan.
Powered by blists - more mailing lists