linux-kernel - Re: [RFC PATCH] mm/oom_kill: allow oom kill allocating task for non-global case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c205367d-f47e-61f3-3aed-fd8142a0010f@i-love.sakura.ne.jp>
Date:   Thu, 10 Jun 2021 23:06:47 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:     Aaron Tomlin <atomlin@...hat.com>, Michal Hocko <mhocko@...e.com>
Cc:     Waiman Long <llong@...hat.com>, Shakeel Butt <shakeelb@...gle.com>,
        Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] mm/oom_kill: allow oom kill allocating task for
 non-global case

On 2021/06/10 22:36, Aaron Tomlin wrote:
> On Thu 2021-06-10 14:43 +0200, Michal Hocko wrote:
>> Well, I am not sure this is a good thing in general. We do not want to
>> hide tasks. We already do display oom_score_adj_min even though they are
>> not eligible and that can serve a good purpose from my experience. It
>> gives us some picture at least. Maybe a flag to mark all uneligible
>> tasks would be something useful but I wouldn't drop them from the list.
> 
> Fair enough.

Yes, marking ineligible (i.e. oom_badness() returning LONG_MIN) tasks would be useful.

By the way, was the task namely "node" (i.e. PID 1703345) multithreaded program?
Your kernel might want commit 7775face207922ea ("memcg: killed threads should not invoke memcg OOM killer").