linux-kernel - Re: [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail instead of list_del/list_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Jun 2021 22:17:12 +0800
From:   Peter Chen <peter.chen@...nel.org>
To:     Baokun Li <libaokun1@...wei.com>
Cc:     linux-kernel@...r.kernel.org, Pawel Laszczak <pawell@...ence.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        weiyongjun1@...wei.com, yuehaibing@...wei.com,
        yangjihong1@...wei.com, yukuai3@...wei.com,
        linux-usb@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next v2] usb: cdns3: cdns3-gadget: Use list_move_tail
 instead of list_del/list_add_tail

On 21-06-09 15:27:20, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> ---
> V1->V2:
> 	CC mailist
> 
>  drivers/usb/cdns3/cdns3-gadget.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index 57adcdbfab5f..5d8c982019af 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -430,9 +430,7 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev,
>  		if (ret)
>  			return ret;
>  
> -		list_del(&request->list);
> -		list_add_tail(&request->list,
> -			      &priv_ep->pending_req_list);
> +		list_move_tail(&request->list, &priv_ep->pending_req_list);
>  		if (request->stream_id != 0 || (priv_ep->flags & EP_TDLCHK_EN))
>  			break;
>  	}
> 

Applied, thanks.

-- 

Thanks,
Peter Chen