linux-kernel - Re: [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df7ef907-815a-868d-006b-515c3bceeed8@oracle.com>
Date:   Thu, 10 Jun 2021 09:32:11 -0500
From:   Himanshu Madhani <himanshu.madhani@...cle.com>
To:     Baokun Li <libaokun1@...wei.com>, linux-kernel@...r.kernel.org,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     weiyongjun1@...wei.com, yuehaibing@...wei.com,
        yangjihong1@...wei.com, yukuai3@...wei.com,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of
 list_del/list_add_tail in qla_target.c



On 6/9/21 2:23 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in qla_target.c.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> ---
> V1->V2:
> 	CC mailist
> 
>   drivers/scsi/qla2xxx/qla_target.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 12a6848ade43..eb47140a899f 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -5481,8 +5481,7 @@ qlt_free_qfull_cmds(struct qla_qpair *qpair)
>   			    "%s: Unexpected cmd in QFull list %p\n", __func__,
>   			    cmd);
>   
> -		list_del(&cmd->cmd_list);
> -		list_add_tail(&cmd->cmd_list, &free_list);
> +		list_move_tail(&cmd->cmd_list, &free_list);
>   
>   		/* piggy back on hardware_lock for protection */
>   		vha->hw->tgt.num_qfull_cmds_alloc--;
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering