linux-kernel - Re: [PATCH V3 net-next 1/4] dt-bindings: net: add dt binding for realtek rtl82xx phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210610025438.GA720819@robh.at.kernel.org>
Date:   Wed, 9 Jun 2021 21:54:38 -0500
From:   Rob Herring <robh@...nel.org>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     davem@...emloft.net, kuba@...nel.org, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk, f.fainelli@...il.com,
        Jisheng.Zhang@...aptics.com, linux-imx@....com,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 net-next 1/4] dt-bindings: net: add dt binding for
 realtek rtl82xx phy

On Tue, Jun 08, 2021 at 11:15:32AM +0800, Joakim Zhang wrote:
> Add binding for realtek rtl82xx phy.
> 
> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> ---
>  .../bindings/net/realtek,rtl82xx.yaml         | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> new file mode 100644
> index 000000000000..bb94a2388520
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek RTL82xx PHY
> +
> +maintainers:
> +  - Andrew Lunn <andrew@...n.ch>
> +  - Florian Fainelli <f.fainelli@...il.com>
> +  - Heiner Kallweit <hkallweit1@...il.com>
> +
> +description:
> +  Bindings for Realtek RTL82xx PHYs
> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +properties:
> +  realtek,clkout-disable:
> +    type: boolean
> +    description:
> +      Disable CLKOUT clock, CLKOUT clock default is enabled after hardware reset.
> +
> +

Extra blank line.

> +  realtek,aldps-enable:
> +    type: boolean
> +    description:
> +      Enable ALDPS mode, ALDPS mode default is disabled after hardware reset.
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mdio {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethphy1: ethernet-phy@1 {
> +                reg = <1>;
> +                realtek,clkout-disable;
> +                realtek,aldps-enable;

The schema here will never be applied because there is nothing to match 
on to determine which nodes it is valid. This should have a compatible 
(because ethernet phys are not special).

Rob