linux-kernel - Re: [PATCH v23 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210610154858.GA1864637@robh.at.kernel.org>
Date:   Thu, 10 Jun 2021 10:48:58 -0500
From:   Rob Herring <robh@...nel.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tudor Ambarus <Tudor.Ambarus@...rochip.com>,
        linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
        Michal Simek <monstr@...str.eu>,
        Naga Sureshkumar Relli <nagasure@...inx.com>,
        Amit Kumar Mahapatra <akumarma@...inx.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        helmut.grohne@...enta.de, Srinivas Goud <sgoud@...inx.com>,
        Siva Durga Prasad Paladugu <sivadur@...inx.com>
Subject: Re: [PATCH v23 17/18] dt-bindings: mtd: pl353-nand: Describe this
 hardware controller

On Thu, Jun 10, 2021 at 10:56:53AM +0200, Miquel Raynal wrote:
> Hi Krzysztof,
> 
> Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com> wrote on Thu,
> 10 Jun 2021 10:48:16 +0200:
> 
> > On 10/06/2021 10:20, Miquel Raynal wrote:
> > > Add a yaml description of this NAND controller which is described as a
> > > subnode of the SMC bus.
> > > 
> > > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > > ---
> > >  .../bindings/mtd/arm,pl353-nand-r2p1.yaml     | 53 +++++++++++++++++++
> > >  1 file changed, 53 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
> > > new file mode 100644
> > > index 000000000000..5f126bb9b202
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
> > > @@ -0,0 +1,53 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: PL353 NAND Controller device tree bindings
> > > +
> > > +allOf:
> > > +  - $ref: "nand-controller.yaml"
> > > +
> > > +maintainers:
> > > +  - Miquel Raynal <miquel.raynal@...tlin.com>
> > > +  - Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:  
> > 
> > I think you can skip the "items" here and leave only "const: foo".
> 
> Crap, I missed that one, you're right. I'll wait a bit for Rob's
> feedback and eventually fix it when applying or resend (hopefully) only
> the NAND bits.

Either way is fine.