linux-kernel - Re: [PATCH v5 1/1] perf cs-etm: Split Coresight decode by aux records

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210610155225.GA34238@p14s>
Date:   Thu, 10 Jun 2021 09:52:25 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     James Clark <james.clark@....com>
Cc:     acme@...nel.org, coresight@...ts.linaro.org, leo.yan@...aro.org,
        al.grant@....com, branislav.rankov@....com, denik@...omium.org,
        suzuki.poulose@....com, anshuman.khandual@....com,
        Mike Leach <mike.leach@...aro.org>,
        John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/1] perf cs-etm: Split Coresight decode by aux records

On Thu, Jun 10, 2021 at 04:55:27PM +0300, James Clark wrote:
> 
> 
> On 10/06/2021 13:36, James Clark wrote:
> > +		return auxtrace_queues__add_event(&etm->queues,
> > +					       session,
> > +					       &auxtrace_fragment,
> > +					       file_offset,
> > +					       NULL);
> 
> There's one more indentation error here that I will fix in the next set.

Yes, this one needs fixing and while at it you probably want to fix the stacking
as well:

                return auxtrace_queues__add_event(&etm->queues, session,
                                                  &auxtrace_fragment,
                                                  file_offset, NULL);

Also look for "deccoding" at the end of the second paragraph in the changelog.

Thanks,
Mathieu