[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210610162320.GA1910317@robh.at.kernel.org>
Date: Thu, 10 Jun 2021 11:23:20 -0500
From: Rob Herring <robh@...nel.org>
To: Steven Lee <steven_lee@...eedtech.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...id.au>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@...ts.ozlabs.org>,
open list <linux-kernel@...r.kernel.org>, Hongweiz@....com,
ryan_chen@...eedtech.com, billy_tsai@...eedtech.com
Subject: Re: [PATCH v5 02/10] dt-bindings: aspeed-sgpio: Add ast2600 sgpio
compatibles.
On Tue, Jun 08, 2021 at 06:25:37PM +0800, Steven Lee wrote:
> AST2600 SoC has 2 SGPIO master interfaces one with 128 pins another one
> with 80 pins. Add ast2600-sgpiom0-80 and ast2600-sgpiom-128 compatibles
> and update descriptions to introduce the max number of available gpio
> pins that AST2600 supported.
>
> Signed-off-by: Steven Lee <steven_lee@...eedtech.com>
> Reviewed-by: Andrew Jeffery <andrew@...id.au>
> ---
> Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
> index b2ae211411ff..0e42eded3c1e 100644
> --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
> @@ -10,9 +10,10 @@ maintainers:
> - Andrew Jeffery <andrew@...id.au>
>
> description:
> - This SGPIO controller is for ASPEED AST2500 SoC, it supports up to 80 full
> - featured Serial GPIOs. Each of the Serial GPIO pins can be programmed to
> - support the following options
> + This SGPIO controller is for ASPEED AST2400, AST2500 and AST2600 SoC,
> + AST2600 have two sgpio master one with 128 pins another one with 80 pins,
> + AST2500/AST2400 have one sgpio master with 80 pins. Each of the Serial
> + GPIO pins can be programmed to support the following options
> - Support interrupt option for each input port and various interrupt
> sensitivity option (level-high, level-low, edge-high, edge-low)
> - Support reset tolerance option for each output port
> @@ -25,6 +26,8 @@ properties:
> enum:
> - aspeed,ast2400-sgpio
> - aspeed,ast2500-sgpio
> + - aspeed,ast2600-sgpiom-80
> + - aspeed,ast2600-sgpiom-128
If the number of GPIOs is the only difference, then I don't think you
should get rid of ngpios. It's one thing if it varies from one SoC to
the next, but if something is per instance we should have a property.
Rob
Powered by blists - more mailing lists