linux-kernel - Re: [PATCH v36 1/4] scsi: ufs: Introduce HPB feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5694e1e0-1c8c-12ef-3215-3d3413a86ea2@acm.org>
Date:   Thu, 10 Jun 2021 09:45:50 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     daejun7.park@...sung.com, Greg KH <gregkh@...uxfoundation.org>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "huobean@...il.com" <huobean@...il.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        JinHwan Park <jh.i.park@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Dukhyun Kwon <d_hyun.kwon@...sung.com>,
        Keoseong Park <keosung.park@...sung.com>,
        Jaemyung Lee <jaemyung.lee@...sung.com>,
        Jieon Seol <jieon.seol@...sung.com>
Subject: Re: [PATCH v36 1/4] scsi: ufs: Introduce HPB feature

On 6/6/21 9:17 PM, Daejun Park wrote:
> +What:		/sys/class/scsi_device/*/device/hpb_sysfs/hit_cnt
> +Date:		June 2021
> +Contact:	Daejun Park <daejun7.park@...sung.com>
> +Description:	This entry shows the number of reads that changed to HPB read.
> +
> +		The file is read only.

This patch introduces the hit_cnt attribute in the hpb_sysfs directory
and patch 4 moves that attribute to the hpb_stats directory. That is not
how sysfs attributes should be introduced. Please introduce the hit_cnt
attribute in the hpb_stats directory in this patch such that the sysfs
directory does not have to be modified in patch 4.

Thanks,

Bart.