linux-kernel - Re: [PATCH] counter: interrupt-cnt: Add const qualifier for actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210610032347.wb4wcwr37p7qn7j7@pengutronix.de>
Date:   Thu, 10 Jun 2021 05:23:47 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     jic23@...nel.org, linux@...pel-privat.de,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH] counter: interrupt-cnt: Add const qualifier for
 actions_list array

Hi William,

On Thu, Jun 10, 2021 at 10:36:42AM +0900, William Breathitt Gray wrote:
> The struct counter_synapse actions_list member expects a const enum
> counter_synapse_action array. This patch renames
> interrupt_cnt_synapse_actionss to interrupt_cnt_synapse_actions and adds
> a const qualifier to match actions_list.
> 
> Cc: Oleksij Rempel <o.rempel@...gutronix.de>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>

Reviewed-by: <o.rempel@...gutronix.de>

thank you!

> ---
>  drivers/counter/interrupt-cnt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
> index 827d785e19b4..5df7cd13d4c7 100644
> --- a/drivers/counter/interrupt-cnt.c
> +++ b/drivers/counter/interrupt-cnt.c
> @@ -77,7 +77,7 @@ static const struct counter_count_ext interrupt_cnt_ext[] = {
>  	},
>  };
>  
> -static enum counter_synapse_action interrupt_cnt_synapse_actionss[] = {
> +static const enum counter_synapse_action interrupt_cnt_synapse_actions[] = {
>  	COUNTER_SYNAPSE_ACTION_RISING_EDGE,
>  };
>  
> @@ -194,8 +194,8 @@ static int interrupt_cnt_probe(struct platform_device *pdev)
>  	priv->counter.signals = &priv->signals;
>  	priv->counter.num_signals = 1;
>  
> -	priv->synapses.actions_list = interrupt_cnt_synapse_actionss;
> -	priv->synapses.num_actions = ARRAY_SIZE(interrupt_cnt_synapse_actionss);
> +	priv->synapses.actions_list = interrupt_cnt_synapse_actions;
> +	priv->synapses.num_actions = ARRAY_SIZE(interrupt_cnt_synapse_actions);
>  	priv->synapses.signal = &priv->signals;
>  
>  	priv->cnts.name = "Channel 0 Count";
> -- 
> 2.32.0
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |