linux-kernel - Re: [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is not defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210610171052.GF34238@p14s>
Date:   Thu, 10 Jun 2021 11:10:52 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is
 not defined

On Fri, Jun 04, 2021 at 06:05:49PM +0200, Arnaud Pouliquen wrote:
> This is a minor fix.
> 
> According to the description of the rpmsg_create_ept in rpmsg_core.c
> the function should return NULL on error.
> 

You are correct, and none of the client return an error code either.

> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>
> ---
>  include/linux/rpmsg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h
> index d97dcd049f18..a8dcf8a9ae88 100644
> --- a/include/linux/rpmsg.h
> +++ b/include/linux/rpmsg.h
> @@ -231,7 +231,7 @@ static inline struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev
>  	/* This shouldn't be possible */
>  	WARN_ON(1);
>  
> -	return ERR_PTR(-ENXIO);
> +	return NULL;

Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org>

>  }
>  
>  static inline int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len)
> -- 
> 2.17.1
>