linux-kernel - Re: [PATCH] ACPI: power: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Jun 2021 19:02:03 +0200
From:   Borislav Petkov <bp@...e.de>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Linux ACPI <linux-acpi@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: power: Use dev_dbg() to print some messages

On Fri, Jun 11, 2021 at 06:58:48PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The messages printed by acpi_resume_power_resources() and
> acpi_turn_off_unused_power_resources() are not important enough to be
> printed with pr_info(), so use dev_dbg() instead of it to get rid of
> some noise in the kernel log.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/acpi/power.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-pm/drivers/acpi/power.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/power.c
> +++ linux-pm/drivers/acpi/power.c
> @@ -1004,7 +1004,7 @@ void acpi_resume_power_resources(void)
>  
>  		if (state == ACPI_POWER_RESOURCE_STATE_OFF
>  		    && resource->ref_count) {
> -			dev_info(&resource->device.dev, "Turning ON\n");
> +			dev_dbg(&resource->device.dev, "Turning ON\n");
>  			__acpi_power_on(resource);
>  		}
>  
> @@ -1034,7 +1034,7 @@ void acpi_turn_off_unused_power_resource
>  		 */
>  		if (!resource->ref_count &&
>  		    resource->state != ACPI_POWER_RESOURCE_STATE_OFF) {
> -			dev_info(&resource->device.dev, "Turning OFF\n");
> +			dev_dbg(&resource->device.dev, "Turning OFF\n");
>  			__acpi_power_off(resource);
>  		}

Acked-by: Borislav Petkov <bp@...e.de>

Thx!

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg