linux-kernel - Re: [PATCH v29 07/13] mm/damon: Implement a debugfs-based user space interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8687948-649f-348f-e4d6-2175b1c47551@amazon.com>
Date:   Fri, 11 Jun 2021 20:59:04 +0200
From:   <sieberf@...zon.com>
To:     <sj38.park@...il.com>
CC:     <Jonathan.Cameron@...wei.com>, <acme@...nel.org>,
        <akpm@...ux-foundation.org>, <alexander.shishkin@...ux.intel.com>,
        <amit@...nel.org>, <benh@...nel.crashing.org>,
        <brendanhiggins@...gle.com>, <corbet@....net>, <david@...hat.com>,
        <dwmw@...zon.com>, <elver@...gle.com>, <fan.du@...el.com>,
        <foersleo@...zon.de>, <greg@...ah.com>, <gthelen@...gle.com>,
        <guoju.fgj@...baba-inc.com>, <linux-damon@...zon.com>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>, <mgorman@...e.de>, <minchan@...nel.org>,
        <mingo@...hat.com>, <namhyung@...nel.org>, <peterz@...radead.org>,
        <riel@...riel.com>, <rientjes@...gle.com>, <rostedt@...dmis.org>,
        <rppt@...nel.org>, <shakeelb@...gle.com>, <shuah@...nel.org>,
        <sjpark@...zon.de>, <snu@...zon.de>, <vbabka@...e.cz>,
        <vdavydov.dev@...il.com>, <zgf574564920@...il.com>
Subject: Re: [PATCH v29 07/13] mm/damon: Implement a debugfs-based user space
 interface

+ Returns non-empty string on success, negarive error code otherwise.

Nit: typo, 'negarive'


+    if (ctx->kdamond) {
+        if (targetid_is_pid(ctx))
+            dbgfs_put_pids(targets, nr_targets);
+        ret = -EBUSY;
+        goto unlock_out;

I don't understand this block, what does EBUSY mean in this context?

+    if (sscanf(kbuf, "%s", kbuf) != 1) {
+        kfree(kbuf);
+        return -EINVAL;
+    }

Nit, this diverts from other patterns use elsewhere where error 
conditions that need to free memory use a goto label.