linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am64-main: Add SYSFW reserved ranges in OCRAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210611190325.6mg4nzhreotsn3db@attribute>
Date:   Fri, 11 Jun 2021 14:03:25 -0500
From:   Nishanth Menon <nm@...com>
To:     Vignesh Raghavendra <vigneshr@...com>
CC:     Lokesh Vutla <lokeshvutla@...com>,
        Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am64-main: Add SYSFW reserved ranges
 in OCRAM

On 23:59-20210611, Vignesh Raghavendra wrote:
> 
> 
> On 6/9/21 8:56 PM, Lokesh Vutla wrote:
> > 
> > 
> > On 09/06/21 7:36 pm, Vignesh Raghavendra wrote:
> >> Last 256K of OCRAM (256K@...01c0000) is reserved for SYSFW usage. Hence
> >> add an entry in DT so that its not used for generic pool memory
> >> allocation.
> >>
> >> Without this certain drivers using SRAM as generic shared memory pool
> >> may end up being allocated memory from this range and will lead to boot
> >> time crash when the reserved range is accessed (due to firewall
> >> violation).
> >>
> >> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> > 
> > You might want to re-base on top of Aswath's patch updating ATF address. Otherwise:
> > 
> > Reviewed-by: Lokesh Vutla <lokeshvutla@...com>
> > 
> 
> Actually, this patch should go in before Aswath's patch as moving ATF
> location around exposed issue of drivers getting memory allocations
> overlapping SYSFW reserved ranges


I have applied Aswath's patch, please rebase. understood this is a bug,
but either way, it really was'nt a regression of stuff that was present.

please fix and send asap so that I can pick it up.
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D