linux-kernel - [PATCH net-next 0/8] net: qualcomm: rmnet: MAPv4 download checksum cleanup, part 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210611190529.3085813-1-elder@linaro.org>
Date:   Fri, 11 Jun 2021 14:05:21 -0500
From:   Alex Elder <elder@...aro.org>
To:     subashab@...eaurora.org, stranche@...eaurora.org,
        davem@...emloft.net, kuba@...nel.org
Cc:     bjorn.andersson@...aro.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH net-next 0/8] net: qualcomm: rmnet: MAPv4 download checksum cleanup, part 1

I'm posting a large series an two smaller parts; this is part 1.

The RMNet driver handles MAP (or QMAP) protocol traffic.  There are
several versions of this protocol.  Version 1 supports multiplexing,
as well as aggregation of packets in a single buffer.  Version 4
adds the ability to perform checksum offload.  And version 5
implements checksum offload in a different way from version 4.

This series involves only MAPv4 protocol checksum offload, and only
in the download (RX) direction.  It affects handling of checksums
computed by hardware for UDP datagrams and TCP segments, carried
over both IPv4 and IPv6.

MAP packets arriving on an RMNet port implementing MAPv4 checksum
offload are passed to rmnet_map_checksum_downlink_packet() for
handling.

The packet is then passed to rmnet_map_ipv4_dl_csum_trailer() or
rmnet_map_ipv6_dl_csum_trailer(), depending contents of the MAP
payload.  These two functions interpret checksum metadata to
determine whether the checksum in the received packet matches that
calculated by the hardware.

It is these two functions that are the subject of this series (parts
1 and 2).  The bulk of these functions are transformed--in a lot of
small steps--from an extremely difficult-to-follow block of checksum
processing code into a fairly simple, heavily commented equivalent.

					-Alex

Alex Elder (8):
  net: qualcomm: rmnet: use ip_is_fragment()
  net: qualcomm: rmnet: eliminate some ifdefs
  net: qualcomm: rmnet: get rid of some local variables
  net: qualcomm: rmnet: simplify rmnet_map_get_csum_field()
  net: qualcomm: rmnet: IPv4 header has zero checksum
  net: qualcomm: rmnet: clarify a bit of code
  net: qualcomm: rmnet: avoid unnecessary byte-swapping
  net: qualcomm: rmnet: avoid unnecessary IPv6 byte-swapping

 .../ethernet/qualcomm/rmnet/rmnet_config.h    |   1 +
 .../ethernet/qualcomm/rmnet/rmnet_map_data.c  | 179 +++++++++---------
 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c   |   1 +
 3 files changed, 92 insertions(+), 89 deletions(-)

-- 
2.27.0