linux-kernel - RE: RE: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1891546521.01623381481630.JavaMail.epsvc@epcpadp4>
Date:   Fri, 11 Jun 2021 10:54:04 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     정요한(JOUNG YOHAN) Mobile SE 
        <yohan.joung@...com>, Daejun Park <daejun7.park@...sung.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "huobean@...il.com" <huobean@...il.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: RE: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support

Hi,

>diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h index 6e6a0252dc15..b1128b0ce486 100644
>--- a/drivers/scsi/ufs/ufshpb.h
>+++ b/drivers/scsi/ufs/ufshpb.h
>@@ -30,19 +30,29 @@
> #define PINNED_NOT_SET                                U32_MAX
> 
> /* hpb support chunk size */
>-#define HPB_MULTI_CHUNK_HIGH                        1
>+#define HPB_LEGACY_CHUNK_HIGH                        1
>+#define HPB_MULTI_CHUNK_LOW                        7
>+#define HPB_MULTI_CHUNK_HIGH                        128
> 
>According to the JEDEC spec, bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD can be set from 4kb to 1024kb. 
>The transfer length should be provided up to 1020kb or 1024kb.
>Why did you set HPB_MULTI_CHUNK_HIGH to 128? 
>It can sends the hpb command up to 512kb. 
>This doesn't seem to match the specs.

I'll fix it in the next patch.

Thanks,
Daejun

>Thanks
>Yohan.
> 
> 
>