Message-ID: <CAD=FV=XTsCvrudDgS2_kX-9e3v+fXVu0yDfzVV+On2_5=JT4=A@mail.gmail.com>
Date:   Fri, 11 Jun 2021 12:37:57 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Sam Ravnborg <sam@...nborg.org>
Cc:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Thierry Reding <treding@...dia.com>,
        Stanislav Lisovskiy <stanislav.lisovskiy@...el.com>,
        Lyude Paul <lyude@...hat.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Steev Klimaszewski <steev@...i.org>,
        Linus W <linus.walleij@...aro.org>,
        Rob Clark <robdclark@...omium.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Andy Gross <agross@...nel.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Robert Foss <robert.foss@...aro.org>,
        Sandeep Panda <spanda@...eaurora.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 00/11] drm: Fix EDID reading on ti-sn65dsi86 by
 introducing the DP AUX bus

Hi,

On Fri, Jun 11, 2021 at 10:18 AM Douglas Anderson <dianders@...omium.org> wrote:
>
> The primary goal of this series is to try to properly fix EDID reading
> for eDP panels using the ti-sn65dsi86 bridge.
>
> Previously we had a patch that added EDID reading but it turned out
> not to work at bootup. This caused some extra churn at bootup as we
> tried (and failed) to read the EDID several times and also ended up
> forcing us to use the hardcoded mode at boot. With this patch series I
> believe EDID reading is reliable at boot now and we never use the
> hardcoded mode.
>
> High level note: in this series the EDID reading is driven by the
> panel driver, not by the bridge chip driver. I believe this makes a
> reasonable amount of sense since the panel driver already _could_
> drive reading the EDID if provided with the DDC bus and in future
> planned work we'll want to give the panel driver the DDC bus (to make
> decisions based on EDID) and the AUX bus (to control the
> backlight). There are also planned patches from Laurent to make
> ti-sn65dsi86 able to drive full DP monitors. In that case the bridge
> chip will still be in charge of reading the EDID, but it's not hard to
> make this dynamic.
>
> This series is the logical successor to the 3-part series containing
> the patch ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only
> if refclk") [1].
>
> This patch was tested against drm-misc-next commit f42498705965
> ("drm/panfrost: Fix missing clk_disable_unprepare() on error in
> panfrost_clk_init()") on a sc7180-trogdor-lazor device.
>
> At v10 now, this is ready to land and I plan to commit it shortly. All
> patches have reviews and Laurent has said over IRC he doesn't object
> it it landing.

I've pushed this to drm-misc-next. I know it's only been a few hours
since I posted it to the lists, but it's the same as v9 that's been
sitting there for a while, except for checking the result of kazalloc
that Lyude noticed (thanks!). I'm not aware of anyone else planning to
add reviews and presume that if they were going to speak up they'd
have done it by now.

While landing, the "dim" tools pointed out two whitespace issues in
patch #4 which I fixed while applying.

Thanks to everyone for all the reviews and help in getting this
whipped into shape!

-Doug

Powered by blists - more mailing lists