linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: Add support for SONY Xperia 1 / 5 (Kumano platform)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fec843d-4e99-b7e9-0502-62b89b108038@somainline.org>
Date:   Sat, 12 Jun 2021 00:20:07 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     martin.botka@...ainline.org, marijn.suijten@...ainline.org,
        jamipkettunen@...ainline.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add support for SONY Xperia 1 / 5
 (Kumano platform)

Il 11/06/21 22:33, Konrad Dybcio ha scritto:
> Add support for SONY Xperia 1 and 5 smartphones, both based on the
> Qualcomm SM8150 chipset. There also exist 5G-capable versions of these
> devices, but they weren't sold much (if at all) outside Japan.
> 
> The devices are affected by a scary UFS behaviour where sending a certain UFS
> command (which is worked around on downstream) renders the device unbootable,
> by effectively erasing the bootloader. Therefore UFS AND UFSPHY are strictly
> disabled for now.
> 
> Downstream workaround:
> https://github.com/kholk/kernel/commit/2e7a9ee1c91a016baa0b826a7752ec45663a0561
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Tested on Xperia 1 (Griffin) with a small initrd system (sorry, no time
to flash a full fledged system!) and boots just fine.

On a note, I would like to bring to the attention of other developers
that we actually tried to get informations about the UFS quirks that
all Sony devices require, as they seem to be required "on purpose",
meaning that it's not a hardware/firmware bug, but rather an intentional
"feature", but nobody has been open to give such informations to us,
which made us unable to understand what's the best way to address this
kind of quirk here on mainline.

If anybody has such informations, or if anybody can give us a hint about
how can we properly/cleanly implement the Sony UFS quirks, we're totally
open for any kind of suggestion.

Thanks!

Reviewed-by: AngeloGioacchino Del Regno 
<angelogioacchino.delregno@...ainline.org>
Tested-by: AngeloGioacchino Del Regno 
<angelogioacchino.delregno@...ainline.org>