lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 11 Jun 2021 10:28:10 +0200
From:   Peter Zijlstra <>
To:     Thomas Gleixner <>,
        Ingo Molnar <>,
        Peter Zijlstra <>,
        Juri Lelli <>,
        Vincent Guittot <>,
        Dietmar Eggemann <>,
        Steven Rostedt <>,
        Ben Segall <>, Mel Gorman <>,
        Daniel Bristot de Oliveira <>
Cc:     Borislav Petkov <>,,
        "H. Peter Anvin" <>, Jens Axboe <>,
        Alasdair Kergon <>,
        Mike Snitzer <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Felipe Balbi <>,
        Greg Kroah-Hartman <>,
        Alexander Viro <>,
        Tejun Heo <>, Zefan Li <>,
        Johannes Weiner <>,
        Jason Wessel <>,
        Daniel Thompson <>,
        Douglas Anderson <>,
        Arnaldo Carvalho de Melo <>,
        Mark Rutland <>,
        Alexander Shishkin <>,
        Jiri Olsa <>,
        Namhyung Kim <>,
        "Rafael J. Wysocki" <>,
        Pavel Machek <>, Will Deacon <>,
        Waiman Long <>,
        Boqun Feng <>,
        Oleg Nesterov <>,
        Davidlohr Bueso <>,
        "Paul E. McKenney" <>,
        Josh Triplett <>,
        Mathieu Desnoyers <>,
        Lai Jiangshan <>,
        Joel Fernandes <>,
        John Stultz <>,
        Stephen Boyd <>,
        Andrew Morton <>,
        Paolo Bonzini <>,
        Stephen Rothwell <>,,
Subject: [PATCH v2 0/7] Cleanup task_struct::state


The task_struct::state variable is a bit odd in a number of ways:

 - it's declared 'volatile' (against current practises);
 - it's 'unsigned long' which is a weird size;
 - it's type is inconsistent when used for function arguments.

These patches clean that up by making it consistently 'unsigned int', and
replace (almost) all accesses with READ_ONCE()/WRITE_ONCE(). In order to not
miss any, the variable is renamed, ensuring a missed conversion results in a
compile error.

The first few patches fix a number of pre-existing errors and introduce a few
helpers to make the final conversion less painful.

This series applies on top of tip/master, and has been having the all-clear
from the robots for the past week.

Since v1:
 - fixed a whole bunch of compile fail on !x86
 - collected tags
 - (slightly) smaller Cc list

The plan is to stick them in tip/sched/core early next week, I'm hoping this
won't cause too much pain for sfr.

Powered by blists - more mailing lists