linux-kernel - Re: [PATCH 5/6] staging: rtl8188eu: remove DebugComponents/DebugLevel from odm_dm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210611090819.GD10983@kadam>
Date:   Fri, 11 Jun 2021 12:08:19 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        straube.linux@...il.com, kaixuxia@...cent.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        liushixin2@...wei.com, unixbhaskar@...il.com,
        gustavoars@...nel.org, martin@...ser.cx, bkkarthik@...u.pes.edu
Subject: Re: [PATCH 5/6] staging: rtl8188eu: remove
 DebugComponents/DebugLevel from odm_dm_struct

On Fri, Jun 11, 2021 at 01:25:03AM +0100, Phillip Potter wrote:
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 80cdcf6f7879..3e7f184ed39a 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -1851,11 +1851,6 @@ u8 rtw_hal_get_def_var(struct adapter *Adapter, enum hal_def_variable eVariable,
>  		}
>  		break;
>  	case HW_DEF_ODM_DBG_FLAG:
> -		{
> -			struct odm_dm_struct *dm_ocm = &haldata->odmpriv;
> -
> -			pr_info("dm_ocm->DebugComponents = 0x%llx\n", dm_ocm->DebugComponents);
> -		}
>  		break;

We will want to delete everything to do with ODM_DBG_FLAG but that can
be done in later patches.

regards,
dan carpenter