linux-kernel - RE: [PATCH][next] cifsd: fix kfree of uninitialized pointer oid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000201d75e5a$5da793d0$18f6bb70$@samsung.com>
Date:   Fri, 11 Jun 2021 09:40:24 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Colin King'" <colin.king@...onical.com>
Cc:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "'Sergey Senozhatsky'" <sergey.senozhatsky@...il.com>,
        "'Steve French'" <sfrench@...ba.org>,
        "'Hyunchul Lee'" <hyc.lee@...il.com>, <linux-cifs@...r.kernel.org>,
        <linux-cifsd-devel@...ts.sourceforge.net>
Subject: RE: [PATCH][next] cifsd: fix kfree of uninitialized pointer oid

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently function ksmbd_neg_token_init_mech_type can kfree an uninitialized pointer oid when the call
> to asn1_oid_decode fails when vlen is out of range. All the other failure cases in function
> asn1_oid_decode set *oid to NULL on an error, so fix the issue by ensuring the vlen out of range error
> also nullifies the pointer.
> 
> Fixes: 8bae4419ce63 ("cifsd: add goto fail in neg_token_init_mech_type()")
> Addresses-Coverity: ("Uninitialized pointer read")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
I will apply, Thanks for your patch!