linux-kernel - Re: [PATCH] thermal/drivers/tsens: fix usage of unititialized value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3db50e86-911a-8b49-8c87-a33178754deb@linaro.org>
Date:   Fri, 11 Jun 2021 07:50:00 -0400
From:   Thara Gopinath <thara.gopinath@...aro.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>, amitk@...nel.org
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, rui.zhang@...el.com,
        daniel.lezcano@...aro.org, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal/drivers/tsens: fix usage of unititialized value



On 6/8/21 5:41 AM, Yang Li wrote:
> When "tsens_version(priv) > VER_0_1" is false,
> "regmap_field_read(priv->rf[VER_MINOR], &ver_minor)" can't execute.
> So, ver_minor has no initialization and assignment before it is
> used, and we initialize it to 0.

Hi Yang,

Thanks for the patch. I have a few questions though.

1. Where do you see ver_minor being used uninitialized? AFAICT , 
ver_minor is used like below and will never be referenced if version <= 
VER_0_1
	if (tsens_version(priv) > VER_1_X &&  ver_minor > 2) {

2. Do you know whether minor versions can be read or not on tsens ips 
with verions < 0_1?

-- 
Warm Regards
Thara (She/Her/Hers)

> 
> Clean up smatch warning:
> drivers/thermal/qcom/tsens.c:896 init_common() error: uninitialized
> symbol 'ver_minor'.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/thermal/qcom/tsens.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 4c7ebd1..a36c43d 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -743,8 +743,8 @@ int __init init_common(struct tsens_priv *priv)
>   {
>   	void __iomem *tm_base, *srot_base;
>   	struct device *dev = priv->dev;
> -	u32 ver_minor;
>   	struct resource *res;
> +	u32 ver_minor = 0;
>   	u32 enabled;
>   	int ret, i, j;
>   	struct platform_device *op = of_find_device_by_node(priv->dev->of_node);
>