linux-kernel - Re: [PATCH -next] xfs: Fix -Wunused-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c36787f3-862e-62af-065b-a13d3a1db054@huawei.com>
Date:   Fri, 11 Jun 2021 20:10:32 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <djwong@...nel.org>, <linux-xfs@...r.kernel.org>,
        <dchinner@...hat.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] xfs: Fix -Wunused-variable warning

PLS ignore this.

On 2021/6/11 19:59, YueHaibing wrote:
> If DEBUG is n, gcc warns:
> 
> fs/xfs/libxfs/xfs_ialloc.c:2032:20: warning: unused variable ‘agi’ [-Wunused-variable]
> 
> Move it info #ifdef block to fix this.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  fs/xfs/libxfs/xfs_ialloc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
> index 2ed6de6faf8a..a9973edd3c0a 100644
> --- a/fs/xfs/libxfs/xfs_ialloc.c
> +++ b/fs/xfs/libxfs/xfs_ialloc.c
> @@ -2029,7 +2029,9 @@ xfs_difree_finobt(
>  	xfs_agino_t			agino,
>  	struct xfs_inobt_rec_incore	*ibtrec) /* inobt record */
>  {
> +#ifdef DEBUG
>  	struct xfs_agi			*agi = agbp->b_addr;
> +#endif
>  	struct xfs_btree_cur		*cur;
>  	struct xfs_inobt_rec_incore	rec;
>  	int				offset = agino - ibtrec->ir_startino;
>