linux-kernel - Re: [PATCH -next] firmware: tegra: Fix build error while ARCH_TEGRA_234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <708178d9-e842-bac0-2f48-c6ce81aaee54@huawei.com>
Date:   Fri, 11 Jun 2021 20:20:54 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <treding@...dia.com>
CC:     <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] firmware: tegra: Fix build error while
 ARCH_TEGRA_234_SOC enabled

Pls ignore this

On 2021/6/11 20:06, YueHaibing wrote:
> drivers/firmware/tegra/bpmp.c:861:51:
>  error: ‘tegra186_soc’ undeclared here (not in a function); did you mean ‘tegra_ivc’?
>   { .compatible = "nvidia,tegra186-bpmp", .data = &tegra186_soc },
>                                                    ^~~~~~~~~~~~
>                                                    tegra_ivc
> 
> Add missing ifdef block to fix this.
> 
> Fixes: 0ebdf11699d0 ("firmware: tegra: Enable BPMP support on Tegra234")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/firmware/tegra/bpmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
> index 0742a90cb844..5654c5e9862b 100644
> --- a/drivers/firmware/tegra/bpmp.c
> +++ b/drivers/firmware/tegra/bpmp.c
> @@ -809,7 +809,8 @@ static const struct dev_pm_ops tegra_bpmp_pm_ops = {
>  };
>  
>  #if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC) || \
> -    IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC)
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
>  static const struct tegra_bpmp_soc tegra186_soc = {
>  	.channels = {
>  		.cpu_tx = {
>