linux-kernel - Re: [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC4tdFUBGUiX4ydq4VeJcEXqmx6f2fvu4cq1ETw5mtueADz6yw@mail.gmail.com>
Date:   Fri, 11 Jun 2021 10:57:59 -0400
From:   Breno Matheus Lima <brenomatheus@...il.com>
To:     Jun Li <jun.li@....com>
Cc:     Breno Matheus Lima <breno.lima@....com>,
        "peter.chen@...nel.org" <peter.chen@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection

Hi Jun,

Em sex., 11 de jun. de 2021 às 02:24, Jun Li <jun.li@....com> escreveu:
>
>
> > -----Original Message-----
> > From: Breno Matheus Lima <breno.lima@....com>
> > Sent: Friday, June 11, 2021 9:48 AM
> > To: peter.chen@...nel.org
> > Cc: gregkh@...uxfoundation.org; shawnguo@...nel.org;
> > s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
> > dl-linux-imx <linux-imx@....com>; linux-usb@...r.kernel.org;
> > linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> > brenomatheus@...il.com; Jun Li <jun.li@....com>; Breno Matheus Lima
> > <breno.lima@....com>
> > Subject: [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection
> >
> > i.MX8MM cannot detect certain CDP USB HUBs. usbmisc_imx.c driver is not
> > following CDP timing requirements defined by USB BC 1.2 specification and
> > section 3.2.4 Detection Timing CDP.
> >
> > During Primary Detection the i.MX device should turn on VDP_SRC and IDM_SINK
> > for a minimum of 40ms (TVDPSRC_ON). After a time of TVDPSRC_ON, the PD is
> > allowed to check the status of the D- line. Current implementation is waiting
> > between 1ms and 2ms, and certain BC 1.2 complaint USB HUBs cannot be detected.
> > Increase delay to 40ms allowing enough time for primary detection.
> >
> > During secondary detection the PD is required to disable VDP_SRC and IDM_SNK,
> > and enable VDM_SRC and IDP_SINK for at least 40ms (TVDMSRC_ON).
> >
> > Current implementation is not disabling VDP_SRC and IDM_SNK, introduce
> > disable sequence in imx7d_charger_secondary_detection() function.
> >
> > VDM_SRC and IDP_SINK should be enabled for at least 40ms (TVDMSRC_ON).
> > Increase delay allowing enough time for detection.
> >
>
> Fixes: 746f316b753a ("usb: chipidea: introduce imx7d USB charger detection")
>

Thanks for pointing this out, I have just sent another version.

Best regards,
Breno Lima