linux-kernel - Re: [PATCH -next] x86/power: fix doc warnings in cpu.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iZwwkKznqxzbkrDK8+gF1todJvg6Yy4DzvZ8enN5khnQ@mail.gmail.com>
Date:   Fri, 11 Jun 2021 18:47:03 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Baokun Li <libaokun1@...wei.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Pavel Machek <pavel@....cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Yue Haibing <yuehaibing@...wei.com>, yangjihong1@...wei.com,
        yu kuai <yukuai3@...wei.com>
Subject: Re: [PATCH -next] x86/power: fix doc warnings in cpu.c

On Tue, Jun 8, 2021 at 4:45 AM Baokun Li <libaokun1@...wei.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  arch/x86/power/cpu.c:76: warning: Function parameter or
>   member 'ctxt' not described in '__save_processor_state'
>  arch/x86/power/cpu.c:192: warning: Function parameter or
>   member 'ctxt' not described in '__restore_processor_state'
>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> ---
>  arch/x86/power/cpu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
> index 3a070e7cdb8b..2640b9128479 100644
> --- a/arch/x86/power/cpu.c
> +++ b/arch/x86/power/cpu.c
> @@ -60,7 +60,7 @@ static void msr_restore_context(struct saved_context *ctxt)
>  /**
>   *     __save_processor_state - save CPU registers before creating a
>   *             hibernation image and before restoring the memory state from it
> - *     @ctxt - structure to store the registers contents in
> + *     @ctxt: structure to store the registers contents in

Any chance to fix the formatting of this kerneldoc comment too in this patch?

>   *
>   *     NOTE: If there is a CPU register the modification of which by the
>   *     boot kernel (ie. the kernel used for loading the hibernation image)
> @@ -183,7 +183,7 @@ static void fix_processor_context(void)
>  /**
>   * __restore_processor_state - restore the contents of CPU registers saved
>   *                             by __save_processor_state()
> - * @ctxt - structure to load the registers contents from
> + * @ctxt: structure to load the registers contents from
>   *
>   * The asm code that gets us here will have restored a usable GDT, although
>   * it will be pointing to the wrong alias.
> --
> 2.31.1
>