linux-kernel - Re: [PATCH v2] mm/page_alloc: Allow high-order pages to be stored on the per-cpu lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210612100706.GE30378@techsingularity.net>
Date:   Sat, 12 Jun 2021 11:07:06 +0100
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Zi Yan <ziy@...dia.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Michal Hocko <mhocko@...nel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCH v2] mm/page_alloc: Allow high-order pages to be stored on
 the per-cpu lists

On Fri, Jun 11, 2021 at 04:23:31PM -0700, Andrew Morton wrote:
> > +static inline int pindex_to_order(unsigned int pindex)
> > +{
> > +	int order = pindex / MIGRATE_PCPTYPES;
> > +
> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > +	if (order > PAGE_ALLOC_COSTLY_ORDER) {
> > +		order = pageblock_order;
> > +		VM_BUG_ON(order != pageblock_order);
> 
> Somebody has trust issues?
> 

Just a little bit :P

> > +	}
> > +#else
> > +	VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER);
> > +#endif
> > +
> > +	return order;
> > +}
> 
> Do we really need all these assertions, long-term?
> 

No, definitely not. Even now it's but already the patch caught me by
surprise (breaking kvm boot) so I'd like to leave them in for at least
one release given the number of changes queued in your tree for the next
merge window.

Thanks.

-- 
Mel Gorman
SUSE Labs