linux-kernel - Re: [PATCH v3] wireless: carl9170: fix LEDS build errors & warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210612103803.30C90C4338A@smtp.codeaurora.org>
Date:   Sat, 12 Jun 2021 10:38:03 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
        kernel test robot <lkp@...el.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        linux-wireless@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3] wireless: carl9170: fix LEDS build errors & warnings

Randy Dunlap <rdunlap@...radead.org> wrote:

> kernel test robot reports over 200 build errors and warnings
> that are due to this Kconfig problem when CARL9170=m,
> MAC80211=y, and LEDS_CLASS=m.
> 
> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>   Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
>   Selected by [m]:
>   - CARL9170_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && CARL9170 [=m]
> 
> CARL9170_LEDS selects MAC80211_LEDS even though its kconfig
> dependencies are not met. This happens because 'select' does not follow
> any Kconfig dependency chains.
> 
> Fix this by making CARL9170_LEDS depend on MAC80211_LEDS, where
> the latter supplies any needed dependencies on LEDS_CLASS.
> 
> Fixes: 1d7e1e6b1b8ed ("carl9170: Makefile, Kconfig files and MAINTAINERS")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Christian Lamparter <chunkeey@...glemail.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: Arnd Bergmann <arnd@...db.de>
> Suggested-by: Christian Lamparter <chunkeey@...glemail.com>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Christian Lamparter <chunkeey@...il.com>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

272fdc0c4542 wireless: carl9170: fix LEDS build errors & warnings

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210530031134.23274-1-rdunlap@infradead.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches