linux-kernel - Re: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9b226219-bf87-4fd4-8d99-9436861ca3cf@www.fastmail.com>
Date:   Sat, 12 Jun 2021 14:24:55 +0200
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Rob Herring" <robh@...nel.org>
Cc:     "Will Deacon" <will@...nel.org>,
        "Robin Murphy" <robin.murphy@....com>,
        "Joerg Roedel" <joro@...tes.org>,
        "Arnd Bergmann" <arnd@...nel.org>, devicetree@...r.kernel.org,
        "Hector Martin" <marcan@...can.st>, linux-kernel@...r.kernel.org,
        "Marc Zyngier" <maz@...nel.org>,
        "Mohamed Mediouni" <mohamed.mediouni@...amail.com>,
        "Stan Skowronek" <stan@...ellium.com>,
        linux-arm-kernel@...ts.infradead.org,
        "Mark Kettenis" <mark.kettenis@...all.nl>,
        "Petr Mladek via iommu" <iommu@...ts.linux-foundation.org>,
        "Alexander Graf" <graf@...zon.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings

Hi,

On Thu, Jun 10, 2021, at 18:52, Rob Herring wrote:
> On Thu, Jun 03, 2021 at 10:50:02AM +0200, Sven Peter wrote:
> > +
> > +examples:
> > +  - |+
> > +    dart1: iommu@...80000 {
> > +      compatible = "apple,t8103-dart";
> > +      reg = <0x82f80000 0x4000>;
> > +      interrupts = <1 781 4>;
> > +      #iommu-cells = <1>;
> > +    };
> > +
> > +    master1 {
> > +      iommus = <&{/dart1} 0>;
> 
> /dart1 is a path, but 'dart1' is a label. You need '&dart1' (or 
> '&{/iommu@...80000}' but that doesn't really work here because the 
> examples get prefixed with /example-n/...)
> 
> With that fixed,
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

Makes sense, thanks for the review!
Fixed for the next version.


Sven