linux-kernel - RE: [PATCH] btrfs: Disable BTRFS on platforms having 256K pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17a401d75f99$662cdc50$328694f0$@codeaurora.org>
Date:   Sat, 12 Jun 2021 09:44:05 -0500
From:   "Brian Cain" <bcain@...eaurora.org>
To:     "'Christophe Leroy'" <christophe.leroy@...roup.eu>,
        "'Chris Mason'" <clm@...com>
Cc:     "'Josef Bacik'" <josef@...icpanda.com>,
        "'David Sterba'" <dsterba@...e.com>,
        <linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
        "'linux-btrfs'" <linux-btrfs@...r.kernel.org>,
        <linux-hexagon@...r.kernel.org>
Subject: RE: [PATCH] btrfs: Disable BTRFS on platforms having 256K pages



> -----Original Message-----
> From: Christophe Leroy <christophe.leroy@...roup.eu>
...
> Le 10/06/2021 à 15:54, Chris Mason a écrit :
> >
> >> On Jun 10, 2021, at 1:23 AM, Christophe Leroy
> <christophe.leroy@...roup.eu> wrote:
> >>
> >> With a config having PAGE_SIZE set to 256K, BTRFS build fails
> >> with the following message
> >>
> >> include/linux/compiler_types.h:326:38: error: call to
> '__compiletime_assert_791' declared with attribute error: BUILD_BUG_ON
> failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) != 0
> >>
> >> BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms
> with
> >> 256K pages at the time being.
> >>
> >> There are two platforms that can select 256K pages:
> >> - hexagon
> >> - powerpc
> >>
> >> Disable BTRFS when 256K page size is selected.
> >>
> >
> > We’ll have other subpage blocksize concerns with 256K pages, but this
> BTRFS_MAX_COMPRESSED #define is arbitrary.  It’s just trying to have an
> upper bound on the amount of memory we’ll need to uncompress a single
> page’s worth of random reads.
> >
> > We could change it to max(PAGE_SIZE, 128K) or just bump to 256K.
> >
> 
> But if 256K is problematic in other ways, is it worth bumping
> BTRFS_MAX_COMPRESSED to 256K ?
> 
> David, in below mail, said that 256K support would require deaper changes. So
> disabling BTRFS
> support seems the easiest solution for the time being, at least for Stable (I
> forgot the Fixes: tag
> and the CC: to stable).
> 
> On powerpc, 256k pages is a corner case, it requires customised binutils, so I
> don't think disabling
> BTRFS is a issue there. For hexagon I don't know.

Larger page sizes like this are typical for hexagon.  Disabling btrfs on hexagon seems appropriate.

-Brian