linux-kernel - Re: [PATCH 0/6] staging: rtl8188eu: remove hal/odm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 12 Jun 2021 18:38:54 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        straube.linux@...il.com, kaixuxia@...cent.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        liushixin2@...wei.com, unixbhaskar@...il.com,
        gustavoars@...nel.org, bkkarthik@...u.pes.edu
Subject: Re: [PATCH 0/6] staging: rtl8188eu: remove hal/odm_debug.h

On Fri, Jun 11, 2021 at 05:35:50PM +0200, Martin Kaiser wrote:
> Thus wrote Dan Carpenter (dan.carpenter@...cle.com):
> 
> > On Fri, Jun 11, 2021 at 01:24:58AM +0100, Phillip Potter wrote:
> > > This series removes hal/odm_debug.h, which contains various preprocessor
> > > definitions, as well as an unwieldy ODM_RT_TRACE macro which is not best
> > > practice. It also removes all uses of this macro, and the associated
> > > fields in struct odm_dm_struct which are only used by this macro.
> 
> > > This makes the code cleaner, thus moving it closer to getting out of
> > > staging.
> 
> > Looks good.
> 
> > Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> same here: looks ok and doesn't break anything
> 
> Reviewed-by: Martin Kaiser <martin@...ser.cx>
> Tested-by: Martin Kaiser <martin@...ser.cx>
> 
> Best regards,
> 
>    Martin

Dear Martin,

Thank you for reviewing and testing.

Regards,
Phil