linux-kernel - Re: [PATCH v2 3/5] ARM: dts: NSP: Add common bindings for MX64/MX65

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <670e1397-1b90-ca8d-c161-6a4c48d6bff4@gmail.com>
Date:   Sat, 12 Jun 2021 19:03:29 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Matthew Hagan <mnhagan88@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>, Rob Herring <robh+dt@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        soc@...nel.org, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Sam Ravnborg <sam@...nborg.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/5] ARM: dts: NSP: Add common bindings for MX64/MX65



On 6/12/2021 4:14 PM, Matthew Hagan wrote:
[snip]
>>> +	pwm-leds {
>>> +		compatible = "pwm-leds";
>>> +
>>> +		red {
>>> +			label = "red:led";
>>> +			pwms = <&pwm 1 50000>;
>>> +		};
>>> +
>>> +		green {
>>> +			label = "green:led";
>>> +			pwms = <&pwm 2 50000>;
>>> +		};
>>> +
>>> +		blue {
>>> +			label = "blue:led";
>>> +			pwms = <&pwm 3 50000>;
>>> +		};
>>> +	};

[snip]

>> What is the reason for overriding this to 2?
> 
> I can't provide an explanation other than that it only works at 2.
> 
> When set to 3 I get the following:
> 
> [    0.784051] OF: /pwm-leds/red: #pwm-cells = 3 found -1
> [    0.789201] of_pwm_get(): can't parse "pwms" property
> [    0.794295] leds_pwm pwm-leds: error -EINVAL: unable to request PWM for red:led
> [    0.801628] leds_pwm: probe of pwm-leds failed with error -22

Strange because with a #pwm-cells value of 3, of_pwm_xlate_with_flags()
would treat the flags as optional so the way you have put it looks
correct to me. I am not sure what the channel sub-nodes are supposed to
do, they do not appear to be documented properties or parsed by the PWM
core?

Is your Device Tree possibly corrupted here?
-- 
Florian