linux-kernel - Re: [PATCH -next 9/9] ASoC: fsl_xcvr: check return value after calling platform_get_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOZdJXUn9FgdhiPAqbxMrz4tSeqQ_S+L9jkpg48NxCo5Fz7PXQ@mail.gmail.com>
Date:   Sun, 13 Jun 2021 09:00:25 -0500
From:   Timur Tabi <timur@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        PowerPC Mailing List <linuxppc-dev@...ts.ozlabs.org>,
        alsa-devel mailing list <alsa-devel@...a-project.org>,
        timur@...nel.org, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH -next 9/9] ASoC: fsl_xcvr: check return value after
 calling platform_get_resource_byname()

On Fri, Jun 11, 2021 at 4:32 AM Yang Yingliang <yangyingliang@...wei.com> wrote:

>         rx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rxfifo");
>         tx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "txfifo");
> +       if (!rx_res || !tx_res) {
> +               dev_err(dev, "Invalid resource\n");
> +               return -EINVAL;
> +       }

If platform_get_resource_byname() returns an error, it's probably
because the name cannot be found.  So I think this error message is
more accurate:

"could not find rxfifo or txfifo resource"