linux-kernel - Re: [PATCH v1] gpio: mt7621: Assign base field in gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Jun 2021 17:51:31 +0200
From:   Reto Schneider <code@...o-schneider.ch>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>, Stefan Roese <sr@...x.de>,
        Reto Schneider <reto.schneider@...qvarnagroup.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] gpio: mt7621: Assign base field in gpio_chip

Hi Andy,

On 13.06.21 14:44, Andy Shevchenko wrote:
> It smells like a fixing non-existing bug. Yes, I understand that there 
> is some custom hardware with custom firmware which is using Linux kernel 
> with some never upstreamed patches. On top of this sysfs interface is 
> deprecated for already a few years and shouldn’t be considered as 1st 
> class citizen.
> 
> That’s said, if there is no Fixes tag provided with clear point that _at 
> some point_ it was like this in upstream, I would tend to NAK this patch.

I did some digging and indeed, it turned out that I used the 
pre-mainline GPIO driver from OpenWRT even on Kernel 4.19 (for which the 
current driver already got mainlined).

Surely do agree on not breaking the interface in mainline, and the NAK.

Sorry for wasting your time!

Kind regards,
Reto