linux-kernel - Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210613162628.2a21d7ea@zhouyanjie-virtual-machine>
Date:   Sun, 13 Jun 2021 16:26:28 +0800
From:   周琰杰 <zhouyanjie@...yeetech.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org,
        peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        sihui.liu@...enic.com, jun.jiang@...enic.com,
        sernia.zhou@...mail.com, paul@...pouillou.net
Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support.

Hi Andrew,

于 Thu, 10 Jun 2021 16:42:24 +0200
Andrew Lunn <andrew@...n.ch> 写道:

> >     We are much more strict about this now than before. You have to
> > use standard units and convert to hardware values. It also makes it
> > a lot easier for DT writers, if they have an idea what the units
> > mean.
> > 
> >     Having the MAC add small delays is something you can add later,
> >     without breaking backwards compatibility. So if you cannot
> > determine what the units are now, just submit the glue driver
> > without support for this feature. If anybody really needs it, they
> > can do the needed research, maybe do some measurements, and then
> > add the code.
> > 
> > 
> > I did an experiment, when the tx delay is not set, RGMII works a  
> 
> You had rgmii-id in your device tree, so that the PHY added the
> delays?

I have tried rgmii-id and rgmii-txid. If we don’t add a fine-tuning
parameter, it still can’t work properly. In these two modes, we still
need to add about 500ps delay on the mac side to ensure it works
properly.

Thanks and best regards!

> 
> 	Andrew