[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YMXaIJWYMX3726Jp@KernelVM>
Date: Sun, 13 Jun 2021 11:12:48 +0100
From: Phillip Potter <phil@...lpotter.co.uk>
To: Joe Perches <joe@...ches.com>
Cc: gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
linux@...ck-us.net, straube.linux@...il.com, martin@...ser.cx,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: convert DBG_88E calls in
core/rtw_sta_mgt.c
On Sat, Jun 12, 2021 at 05:22:33PM -0700, Joe Perches wrote:
> On Sun, 2021-06-13 at 00:28 +0100, Phillip Potter wrote:
> > Convert both calls to the DBG_88E macro in core/rtw_sta_mgt.c into
> > netdev_dbg calls. The DBG_88E macro is unnecessary, as visibility of
> > debug messages can be controlled more precisely by just using debugfs.
> > It is important to keep these messages still, as they are displayable
> > via a kernel module parameter when using DBG_88E.
> []
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> []
> > @@ -113,17 +113,20 @@ u32 _rtw_init_sta_priv(struct sta_priv *pstapriv)
> > inline int rtw_stainfo_offset(struct sta_priv *stapriv, struct sta_info *sta)
> > {
> > int offset = (((u8 *)sta) - stapriv->pstainfo_buf) / sizeof(struct sta_info);
> > + struct net_device *pnetdev = stapriv->padapter->pnetdev;
> >
> >
> > if (!stainfo_offset_valid(offset))
> > - DBG_88E("%s invalid offset(%d), out of range!!!", __func__, offset);
> > + netdev_dbg(pnetdev, "invalid offset(%d), out of range!!!", offset);
>
> better to add terminating newlines to the formats.
>
>
Dear Joe,
Thank you for your feedback. I will republish my two patches with this
change.
Regards,
Phil
Powered by blists - more mailing lists