linux-kernel - Re: [PATCH v4 12/16] firmware: arm_scmi: Add message passing abstractions for transports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210614151036.00000409@Huawei.com>
Date:   Mon, 14 Jun 2021 15:10:36 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Cristian Marussi <cristian.marussi@....com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <virtualization@...ts.linux-foundation.org>,
        <virtio-dev@...ts.oasis-open.org>, <sudeep.holla@....com>,
        <james.quinlan@...adcom.com>, <f.fainelli@...il.com>,
        <etienne.carriere@...aro.org>, <vincent.guittot@...aro.org>,
        <souvik.chakravarty@....com>, <igor.skalkin@...nsynergy.com>,
        <peter.hilber@...nsynergy.com>, <alex.bennee@...aro.org>,
        <jean-philippe@...aro.org>, <mikhail.golubev@...nsynergy.com>,
        <anton.yakovlev@...nsynergy.com>,
        <Vasyl.Vavrychuk@...nsynergy.com>,
        <Andriy.Tryshnivskyy@...nsynergy.com>
Subject: Re: [PATCH v4 12/16] firmware: arm_scmi: Add message passing
 abstractions for transports

On Fri, 11 Jun 2021 17:59:33 +0100
Cristian Marussi <cristian.marussi@....com> wrote:

> From: Peter Hilber <peter.hilber@...nsynergy.com>
> 
> Add abstractions for future transports using message passing, such as
> virtio. Derive the abstractions from the shared memory abstractions.
> 
> Abstract the transport SDU through the opaque struct scmi_msg_payld.
> Also enable the transport to determine all other required information
> about the transport SDU.
> 
> Signed-off-by: Peter Hilber <peter.hilber@...nsynergy.com>
> ---
...
> diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
> index b783ae058c8a..fa4075336580 100644
> --- a/drivers/firmware/arm_scmi/common.h
> +++ b/drivers/firmware/arm_scmi/common.h
> @@ -410,6 +410,21 @@ void shmem_clear_channel(struct scmi_shared_mem __iomem *shmem);
>  bool shmem_poll_done(struct scmi_shared_mem __iomem *shmem,
>  		     struct scmi_xfer *xfer);
>  
> +/* declarations for message passing transports */
> +struct scmi_msg_payld;
> +
> +/** Maximum overhead of message w.r.t. struct scmi_desc.max_msg_size */

Doesn't look to be kernel-doc..

> +#define SCMI_MSG_MAX_PROT_OVERHEAD (2 * sizeof(__le32))