linux-kernel - Re: [PATCH -next 1/2] ACPI: processor_throttling: Remove redundant initialization of 'obj'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Jun 2021 17:20:28 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH -next 1/2] ACPI: processor_throttling: Remove redundant
 initialization of 'obj'

On Thu, Jun 10, 2021 at 11:40 AM Yang Li <yang.lee@...ux.alibaba.com> wrote:
>
> 'obj' is being initialized, however this value is never read as
> 'obj' is assigned an updated value later. Remove the redundant
> initialization.
>
> Clean up clang warning:
> drivers/acpi/processor_throttling.c:409:20: warning: Value stored to
> 'obj' during its initialization is never read
> [clang-analyzer-deadcode.DeadStores]
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/acpi/processor_throttling.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
> index 0086afe..017fd02 100644
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -406,7 +406,7 @@ static int acpi_processor_get_throttling_control(struct acpi_processor *pr)
>         acpi_status status = 0;
>         struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
>         union acpi_object *ptc = NULL;
> -       union acpi_object obj = { 0 };
> +       union acpi_object obj;
>         struct acpi_processor_throttling *throttling;
>
>         status = acpi_evaluate_object(pr->handle, "_PTC", NULL, &buffer);
> --

Applied as 5.14 material, thanks!