linux-kernel - Re: [PATCH v3 2/3] sched/fair: Take thermal pressure into account while estimating energy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81d7bd73-a61a-5501-f8ec-77e195355013@arm.com>
Date:   Mon, 14 Jun 2021 16:29:20 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     vincent.guittot@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        peterz@...radead.org, rjw@...ysocki.net, viresh.kumar@...aro.org,
        qperret@...gle.com, dietmar.eggemann@....com,
        vincent.donnefort@....com, Beata.Michalska@....com,
        mingo@...hat.com, juri.lelli@...hat.com, rostedt@...dmis.org,
        segall@...gle.com, mgorman@...e.de, bristot@...hat.com,
        thara.gopinath@...aro.org, amit.kachhap@...il.com,
        amitk@...nel.org, rui.zhang@...el.com, daniel.lezcano@...aro.org
Subject: Re: [PATCH v3 2/3] sched/fair: Take thermal pressure into account
 while estimating energy

Hi Vincent,

Gentle ping. Could you have a look at this implementation, please?


On 6/10/21 4:03 PM, Lukasz Luba wrote:

[snip]

> @@ -6527,8 +6527,12 @@ compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
>   	struct cpumask *pd_mask = perf_domain_span(pd);
>   	unsigned long cpu_cap = arch_scale_cpu_capacity(cpumask_first(pd_mask));
>   	unsigned long max_util = 0, sum_util = 0;
> +	unsigned long _cpu_cap, thermal_pressure;
>   	int cpu;
>   
> +	thermal_pressure = arch_scale_thermal_pressure(cpumask_first(pd_mask));
> +	_cpu_cap = cpu_cap - thermal_pressure;

I've done the implementation according to your suggestion. That should
provide the consistent usage.

Regards,
Lukasz