linux-kernel - Re: [PATCH] x86: fix get_wchan() not support the ORC unwinder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06292162-5a44-6f91-140d-e1211c006ad0@kernel.org>
Date:   Mon, 14 Jun 2021 09:21:12 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Qi Zheng <zhengqi.arch@...edance.com>, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        peterz@...radead.org, x86@...nel.org
Cc:     linux-kernel@...r.kernel.org, songmuchun@...edance.com
Subject: Re: [PATCH] x86: fix get_wchan() not support the ORC unwinder

On 6/11/21 5:46 AM, Qi Zheng wrote:
> Currently, the kernel CONFIG_UNWINDER_ORC option is enabled by
> default on x86, but the implementation of get_wchan() is still
> based on the frame pointer unwinder, so the /proc/<pid>/wchan
> always return 0 regardless of whether the task <pid> is running.
> 
> We reimplement the get_wchan() by calling stack_trace_save_tsk(),
> which is adapted to the ORC and frame pointer unwinders.

How much slower does this make ps?

--Andy