linux-kernel - Re: [PATCH 09/11] PCI: add matching checks for driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210614163337.GL1002214@nvidia.com>
Date:   Mon, 14 Jun 2021 13:33:37 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Max Gurtovoy <mgurtovoy@...dia.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        cohuck@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, aviadye@...dia.com, oren@...dia.com,
        shahafs@...dia.com, parav@...dia.com, artemp@...dia.com,
        kwankhede@...dia.com, ACurrid@...dia.com, cjia@...dia.com,
        yishaih@...dia.com, kevin.tian@...el.com, targupta@...dia.com,
        shameerali.kolothum.thodi@...wei.com, liulongfang@...wei.com,
        yan.y.zhao@...el.com
Subject: Re: [PATCH 09/11] PCI: add matching checks for driver_override
 binding

On Mon, Jun 14, 2021 at 05:15:22PM +0100, Christoph Hellwig wrote:
> On Mon, Jun 14, 2021 at 01:01:25PM -0300, Jason Gunthorpe wrote:
> > > Isn't struct pci_device_id a userspace ABI due to MODULE_DEVICE_TABLE()?
> > 
> > Not that I can find, it isn't under include/uapi and the way to find
> > this information is by looking for symbols starting with "__mod_"
> > 
> > Debian Code Search says the only place with '"__mod_"' is in
> > file2alias.c at least
> > 
> > Do you know of something? If yes this file should be moved
> 
> Seems lke file2alias.c is indeed the only consumer.  So it is a
> userspace ABI, but ony to a file included in the kernel tree.

As I understand it, things are tighter than that, it is only an API
between different parts of kbuild - so it is OK to change
it. module.alias is the uAPI this data gets marshaled into.

Jason