linux-kernel - Re: [PATCH 7/7] pwm: ep93xx: Prepare clock before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210614072222.wgivnzbaekxxw7qu@pengutronix.de>
Date:   Mon, 14 Jun 2021 09:22:22 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Alexander Sverdlin <alexander.sverdlin@...il.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Nikita Shubin <nikita.shubin@...uefel.me>,
        linux-pwm@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de,
        H Hartley Sweeten <hsweeten@...ionengravers.com>
Subject: Re: [PATCH 7/7] pwm: ep93xx: Prepare clock before using it

On Mon, Jun 14, 2021 at 01:30:41AM +0200, Alexander Sverdlin wrote:
> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> to Common Clock Framework.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

Maybe it would make sense to move the prepare into the probe function?!
Anyhow, for now preparing the driver for the common-clk switch is the
focus and for that the conversion is correct, so:

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)