linux-kernel - Re: [PATCH] net: usbnet: allow overriding of default USB interface naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210614122000.7cdef052@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 14 Jun 2021 12:20:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathan Davies <jonathan.davies@...anix.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Oliver Neukum <oneukum@...e.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        andrew@...n.ch
Subject: Re: [PATCH] net: usbnet: allow overriding of default USB interface
 naming

On Mon, 14 Jun 2021 15:53:53 +0100 Jonathan Davies wrote:
> >> Compare implementations of rename_netif in
> >> https://git.kernel.org/pub/scm/linux/hotplug/udev.git/tree/src/udev-event.c 
> >> (traditional udev, which handles collisions) and
> >> https://github.com/systemd/systemd/blob/main/src/udev/udev-event.c 
> >> (systemd-udevd, which does not handle collisions).  

That explains some user reports I've been seeing :o

> > Then submit a change to add the logic back.  This looks like a userspace
> > tool breaking existing setups, so please take it up with the developers
> > of that tool.  The kernel has not changed or "broken" anything here.  
> 
> (I didn't mean to imply that the kernel was to blame, merely that a 
> kernel change could help make things tidier.)

If you're attempting to fix this in systemd please share the PR info
so we can voice support!